Krisztian Litkey
Krisztian Litkey
/cc @mrunalp @kolyshkin
Just an update/note related to eliminating `github.com/hashicorp/go-multierror` from dependencies: golang 1.20 has now [support for wrapping multiple errors](https://tip.golang.org/doc/go1.20#errors). This hopefully removes the need to rely on an external or internal...
> @klihub the reasoning behind the NRI errors aren't clear to me, can you help me find the issue? @haircommander The test fails, expecting an NRI StopContainer event which it...
> > @klihub the reasoning behind the NRI errors aren't clear to me, can you help me find the issue? @haircommander Okay, I (think I) know what happens. Before the...
@umohnani8 I haven't seen these in a while. I agree, let's close it and re-open if necessary (it ever pops up again).
@yylt: Do you have a use case for this ? I mean, AFAICT this PR tries to add `cgroup v1` support for something that we already should support for `cgroup...
@yylt IMO, for making this really usable and getting it merged, IMO we'd need to put in a few more missing details: - pkg/api: add `ContainerAdjustment` setter, probably `SetLinuxPidLimits(int64)` -...
Okay, so basically instead of injecting a new mount into a container you would like to adjusts the mount type (?) and options of an existing mount which would be...
> In the current implementation, it is not possible to control `pid cgroup` in nri plugin. Could `pid` be included? I think for the cgroup v2 version of the controller...