Krisztian Litkey

Results 285 comments of Krisztian Litkey

> I have an NRI plugin running as a DaemonSet. Ideally, I would like to set `spec.updateStrategy.rollingUpdate.maxSurge` to a positive number, and `spec.updateStrategy.rollingUpdate.maxUnavailable` to zero to have "make before break"...

> Similarly, the cpu.idle parameter is not supported either and can be added. @TonyxSun Are you sure, the `cpu.idle` parameter cannot be adjusted/set using the cgroupv2 `unified` map parameter ?

> Thanks for pointing that out, didn't notice its existence. `cpu.max.burst` can similarly be set using the `unified` map, any benefit to having it be supported as a first class...

> One gap for my use case - I might need to support setting the `cfs_burst_us` v1 field. There isn't a way to do this right now, correct? Yes, I...

> The last issue I encountered is that there appears to be no indication which Events can be subscribed to, but simply selecting all Events may result in the plugin...

> Unfortunately that is really only half the story. Firstly it would be nice to mention that it is using ttrpc instead of grpc This is mentioned in the [README](https://github.com/containerd/nri/blob/c0d45aab05e083b72fae84a5c190968c7eb62b5e/README.md?plain=1#L42),...

@lengrongfu Just thinking aloud about alternative existing possibilities, your plugin could annotate containers it has processed, and if it restarts (due to a timeout or other reasons) it could check...

@lengrongfu Also, I think this should be filed against the core NRI repo, not containerd itself.

> > [@lengrongfu](https://github.com/lengrongfu) Also, I think this should be filed against the core NRI repo, not containerd itself. > > I understand that the design of nri is somewhat similar...