klg71

Results 15 comments of klg71

Hey ghilainm, Thanks for taking the time and opening this issue :) This is definitely a good change to implement but I fear it might take a couple of weeks...

Which dependencies have invalid signatures and which unit tests are stuck? The stuck-unittests could be explainable if the local Keycloak is not started.

My best guess for the failing tests are because you upgraded "io.mockk:mockk:1.12.0" but not "com.nhaarman.mockitokotlin2:mockito-kotlin:2.1.0". AFAIK the both depend on bytebuddy and mockitokotlin doesnt't work with the new version. So...

Hey ghilainm i am currently fixing the master build, cause I found a couple of issues there too. If you could wait 1-2 hours for me to fix it you...

Thanks for your work but these are so many changes that it would be impossible for me to review. I fixed the build issues on the master and you can...

I think its definitely worth looking at and I am really thankful for your commitment at this project. I would suggest we schedule a call to clear up the situtation....

Yeah I did and I hope you accept my apology for my first reaction, that the build was not running. Communication should have been definitely better on my side :/

I guess this would only be applicable for the docker image because if you use the fatJar version you should be able to configure it along the other jvm parameters....

Well if its to inconvienient to add the certificate to the java keystore I think we could need this parameter. If you need it immediately you could file a pull...

Hey @MrDeerly thank you for bringing it up. I looked into it and I guess we can replace the old functionality with the `reset-password` endpoint in the admin api. This...