klein-j

Results 15 comments of klein-j

Suggested fix ======== In `Soloud::calcActiveVoices_internal()` replace the old sorting code which is ``` int left = 0, stack[24], pos = 0, right; int len = candidates - mustlive; unsigned int...

Nice to hear. I attached a diff file in case others want to use the code as well. (The index in line 2 belongs to my repository, maybe the patch...

Making `float *mData` an std::unique_ptr should be a good idea as well. Then it should become directly obvious, when the Sound-Object is attempted to be copied without an proper copy...

No, actually I think `float *mData` really should be `std::vector mData`. The changes are small and it instantaneously fixed all crashes. I will prepare a pull-request. Still for efficiency reasons,...

As I said, I can help fixing this issue by providing some code, but first we should have at least some form of discussion to ensure that a fix will...

Here are the diff files. Renamed as txt for github upload, also the index in line 2 is relative to my own repository, so maybe they can't be applied directly....

Honestly, what really "does not add value" is having a copy-constructor that is implemented wrongly and crashes the program. This is bad, it either has to be removed or fixed....

There are a number of issues with the queue implementation, see my comments here: https://github.com/jarikomppa/soloud/issues/291 I fixed some of them and also added a queue::pop function which can remove elements...

I uploaded my fix (along with some others) here: https://github.com/klein-j/soloud_fixed/tree/soloud_fixed

I also uploaded my fix here: https://github.com/klein-j/soloud_fixed/tree/soloud_fixed