Khyber Sen

I believe this is caused by UB in `analysis/test`. When I reduced `main_0` to just ```rust unsafe fn main_0(mut argc: libc::c_int, mut argv: *mut *mut libc::c_char) -> libc::c_int { simple();...

The significantly rarer race condition in `cargo add` is a separate bug. It is much more rare, though, and we should be able to fix it by adding locking at...

Fixed by: * #683 * #691

Well, this is still failing CI, welp. Some ideas for investigating further that we discussed: * Trying to replicate the CI environment locally as much as possible, like running with...

> What's the high level difference between this and #683 ? This PR is just everything thrown together in 1 commit. There might be some other changes added in here,...

Closing as this was a WIP and is now complete in: * #653 * #683 * #684 * #686 * #698

> One downside I see to this approach is that in some cases it forces the node names in the assertion to be out of order compared to the graph,...

> I think we could get the best of both worlds with a macro along the lines of `assert_unique!(pdg, [a, !j, !b1, !b2, !c1, !c2, d2]);` I don't think we...

> This whole PR is superseded by the approach in #668, right? Yeah, pretty much.

1. It appears `cargo add` has race conditions: [CI](https://dev.azure.com/immunant/c2rust/_build/results?buildId=2408&view=logs&j=fe77950d-5503-5ec3-6c76-15a0f8cc6cf7&t=ce305318-91d2-5c88-823e-602f3c524f91&l=120) ```shell running 2 tests Blocking waiting for file lock on package cache Blocking waiting for file lock on package cache Blocking...