Khyber Sen
Khyber Sen
Yeah, that seems a lot safer to do. Would it be possible to process-parallelize the `clang` and `c2rust-ast-exporter` parts up until serialization, and then from deserialization on, which is all...
Could you also add your PR description as inline documentation, including doc comments as fitting?
If the suggestions look good, I can organize them into commits if you want.
The snapshot you checked is not quite the right one. That's the `*.snap.new` file that's generated when you run `cargo test` and the snapshot fails, the new snapshot. But then...
@spernsteiner, to clarify, is the `UNIQUE` property supposed to be exactly what can be made `&mut` and satisfy the borrow checker? And if it does not satisfy the `UNIQUE` property,...
> Types like `AtomicUsize` are no different from `Cell` for our purposes. We don't have any special handling for interior mutability in the input program. On the static analysis side,...
> I think we should avoid breaking human-edited code, but otherwise shouldn't promise that the tool will actually do anything useful on that code. The analysis and refactoring problems here...
> A high level explanation is here: https://docs.google.com/document/d/1gPkUOLT4I_thFb6LRXSAOpUIVqDQU1MXuYWLMyy50tc/edit?usp=sharing. Can we inline that here?
Isn't aliases the opposite of unique? I much prefer `alias` because it's shorter, it's a verb like the others, and it's saying what it does, not what it doesn't.
If they alias, then they are not unique, by the common definitions of those words. I think in the Rust sense, it's understood that you can't actively use mutably aliased...