Kornilios Kourtis
Kornilios Kourtis
> > Thanks, this looks good to me overall! > > I have some requests for changes. Please let me know if they do not make sense to you. I...
All tests ✅, merging! Thanks!
This is not exactly a failure, the test passes but there is a panic because t.Log is called after a test is completed: ``` PASS panic: Log in goroutine after...
> Warning: WARNING:BAD_SIGN_OFF: 'Co-authored-by:' is the preferred signature form :( Indeed very annoying. Feel free to remove it :)
Thanks @inliquid! Can you reproduce it without `awk` or is `awk` needed for the issue to happen? My guess is that there is some race happening when filling the .Process...
I tried to reproduce this on a bare-metal (non-k8s) machine but couldn't. @inliquid can you check that this is also the case on your side? That is, running the same...
Closing this since most of the work is done! :tada:
> I did one pass, left a few minor comments. I would need a second pass to fully follow the code logic, but looks good overall :) Thanks Anna! I...
> Nice patches! I just skipped this commit [4360fbf](https://github.com/cilium/tetragon/commit/4360fbf9f385d064a3dc7927d4fcd161c62afd3d) to be honest but the rest looks good, here are some comments :) Thanks for the review! Pushed a new version...
Merging this, thanks everyone for the helpful reviews!