tetragon icon indicating copy to clipboard operation
tetragon copied to clipboard

rthooks: support NRI

Open kkourt opened this issue 1 year ago • 1 comments

This is a first PR for supporting NRI (https://github.com/containerd/nri), and having an easy way to install the tetragon runtime hook in containerd. Please see patches.

The idea here (which will be completed in a subsequent PRs) is to:

  • Have a different image for the runtime hooks binaries (tetragon-rthooks)
  • Create a separate daemonset for them, so that they can be independent from the tetragon daemonset)
  • Use this daemonset for the NRI hook (containerd)
  • Also use this daemonest for the CRI-O hook (where now we are using an init container)

kkourt avatar Jun 25 '24 08:06 kkourt

Deploy Preview for tetragon ready!

Name Link
Latest commit eee94a3c91fcc2ea2fb1d53378c1a7c43aeec8cd
Latest deploy log https://app.netlify.com/sites/tetragon/deploys/66879c463eb7900008638296
Deploy Preview https://deploy-preview-2608--tetragon.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 25 '24 08:06 netlify[bot]

I did one pass, left a few minor comments. I would need a second pass to fully follow the code logic, but looks good overall :)

Thanks Anna! I addressed the comments.

kkourt avatar Jul 04 '24 09:07 kkourt

Nice patches! I just skipped this commit 4360fbf to be honest but the rest looks good, here are some comments :)

Thanks for the review! Pushed a new version to address the comments.

kkourt avatar Jul 04 '24 13:07 kkourt

Merging this, thanks everyone for the helpful reviews!

kkourt avatar Jul 05 '24 13:07 kkourt