Benjamin Byholm
C++11 should be perfectly fine, since no new code will be written for versions below 4.
I like the idea of a configurable trait. If someone were to write a good implementation as a pull request, I would be happy to merge it. The current documentation...
Without looking into it further, I would guess not. For legacy reasons, NAN does not support Symbols. On August 24, 2017 9:16:15 PM GMT+03:00, Steve Lam wrote: >Would it be...
While the signatures have never been widely in use, I am not too keen on outright changing the NAN API, since that would be a breaking change. Existing code should...
Based on `auto dataPtr = static_cast(dataBuffer->GetContents().Data());` working and it not crashing when you comment out https://github.com/nodejs/nan/blob/main/nan_typedarray_contents.h#L37, I suspect that something is off in a mismatch between the version of V8...
> Hmm, but that doesn't explain why a single call `static_cast(dataBuffer->GetBackingStore()->Data());` works, but doing it twice crashes I missed that doing it twice causes a problem. However, `auto test =...
Strange, I did get a compile time error with Apple clang version 12.0.0 (clang-1200.0.32.29) Target: x86_64-apple-darwin19.6.0 when trying it.
Ah, problem is C++17.
Trying to do a std::move() fails as expected. Perhaps C++17 allows this assignment expression because it is guaranteed to be identical to directly using the constructor as `foo(arg);`? Either way,...
Based on what @addaleax mentioned, the `std::shared_ptr` in the backtrace does stick out.