Results 148 comments of Benjamin Byholm

As far as I can tell from looking at the code, these `Utf8String`s are never deleted and will therefore leak. The above suggestion ought to work, as should this: ```...

Actually, it used to be that way, but was changed in b2efc95d093c4aff9057fe6c7a43702f8d0d23cb. If there actually was a segmentation fault somewhere, it means that libgeoip does something wrong or strange with...

Node-pre-gyp seems like a good solution for many problems of this nature. @springmeyer would you recommend using node-pre-gyp for this purpose?

Thank you. I am concerned about the signature changes. It seems like it should be possible to paper over the differences without breaking the NAN API. Assuming that v8::AccessControl is...

Yes, that might work. All I want is to avoid breaking NANs API directly while retaining the same observable behavior across versions. I remember dealing with something similar in one...

Wonderful. That makes it a lot easier. Now, I would still like to have `Nan::SetAccessor` as it is in this PR deprecated and a new one added which does not...

The main reason why it does not exist is because the function it papers over does not have an overload accepting a `const char *`. While NAN does contain some...

If it were to be added, I would prefer it to be polymorphic (through overload or template, whichever is best for this). I had a quick glance at the code...

That is not how the options are called, so it is evident that it will not work. The options are called `ZMQ_RCVTIMEO` and `ZMQ_SNDTIMEO`.