Kimmo Lehto

UserSettings functions should have the same signature as Config

2

I can't do something like this: ```go type sshconfig interface { GetAll(alias, key string) ([]string, error) } var sshConfig sshconfig func initSshConfig() { if path := os.Getenv("SSH_CONFIG"); path != ""...

There should be batching and I'm almost sure there used to be, I think it may have been lost with the dry-run mechanism.

The host.configurer interface is humongous. Trying to come up with ways to bring some sense to it.

Before: ```yaml apiVersion: k0sctl.k0sproject.io/v1beta1 kind: Cluster metadata: name: k0s-cluster spec: hosts: - ssh: address: 10.0.0.1 user: root port: 22 keyPath: null role: controller - ssh: address: 10.0.0.2 user: root port:...

Reset fails to unmount/unlink /var/lib/k0s on alpine

3

```log time="2023-10-06T08:41:06Z" level=debug msg="[ssh] 127.0.0.1:9023: resetting k0s..." time="2023-10-06T08:41:06Z" level=debug msg="[ssh] 127.0.0.1:9023: executing `/usr/local/bin/k0s reset --data-dir=/var/lib/k0s`" time="2023-10-06T08:41:07Z" level=debug msg="[ssh] 127.0.0.1:9023: (stderr) time=\"2023-10-06 08:41:07\" level=warning msg=\"failed to unmount /var/lib/k0s\"" time="2023-10-06T08:41:07Z" level=debug msg="[ssh]...

This simplifies the interface a bit and removes the need to pass datadir/host around.

Use actions/setup-go@v5 in github actions

7

## Description Use actions/setup-go@v5 instead of v3. Closes #3795 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking...

Bump spf13/cobra to 1.8.0 and adapt PersistentPreRun usage

8

* Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.7.0 to 1.8.0. * Adapts the use of `PersistentPreRun`, removed the `CallParentPersistentPreRun` and enabled `cobra.EnableTraverseRunHooks` - see https://github.com/spf13/cobra/pull/2044 Release notes Sourced from github.com/spf13/cobra's releases. v1.8.0 ✨...

Bump logrus to v1.9.3 + remove buffer overflow workaround

10

## Description Reverts changes made in #2674 that were done to work around bug https://github.com/sirupsen/logrus/issues/1370 in logrus that was fixed in https://github.com/sirupsen/logrus/pull/1384 and released as v1.9.3 ## Type of change...

Extra arguments from K0S_EXTRA_ARGS in service startup

7

## Description This was talked about at some point. This will make the service script installed by `k0s install` read extra arguments from `K0S_EXTRA_ARGS`. This can be defined in: -...