Yan Wang

Hi @kshitij12345 I created [this issue](https://github.com/Lightning-AI/lightning-thunder/issues/2148) as a follow-up discussion. I did a quick check on the checker functions in other executors, and it seems they work correctly with NumberProxy...

Hi @t-vi , @mruberry , it's ready to merge

Hi Ivan, With a patch (I'll commit this): ``` wayan@3d0e6ea-lcedt:~/lightning-thunder$ git diff thunder/dynamo/report.py diff --git a/thunder/dynamo/report.py b/thunder/dynamo/report.py index c8af6223..a1480269 100644 --- a/thunder/dynamo/report.py +++ b/thunder/dynamo/report.py @@ -1351,4 +1351,4 @@ def save_failing_repros(...

The `test_hf_for_nemo` has been updated. When running `pytest thunder/tests/test_networks.py -k test_hf_for_nemo[qwen2] -vs` with both transformers==4.50.3 and the current required version 4.52.4, there are no accuracy issues observed. Given this, do...

I noticed that if we change the test case here: https://github.com/Lightning-AI/lightning-thunder/blob/d6455982d5ca6815efd3d7dc0341b4f945f99be5/thunder/tests/test_jit_general.py#L1206-L1217 to use `torch.sin(x)`, it gives the similar error, so it could be the repro: "TypeError: sin(): argument 'input' (position...

Examples: Dynamo segments the graph into some subgraphs, each identified by the 'GraphId[id]' field in the test name. Each subgraph can contain multiple split modules, processed by the Thunder-defined splitter,...

Hi @tfogal @IvanYashchuk @crcrpar , can we merge this initial PR first, we can discuss the additional requirements in the new issue(https://github.com/Lightning-AI/lightning-thunder/issues/1258)

Hi @IvanYashchuk @t-vi , I think it's ready to merge, do you want to have another look?