Yan Wang
Yan Wang
Hi @IvanYashchuk @t-vi , I think it's ready to merge, set the numberproxy to none works fine in this PR, but will cause the input to nvfusion in the backward...
> The PR description has only the "before" trace. Could you please update it adding how the trace looks like with this PR? Trace after this PR(based on branch [uniform_rng](https://github.com/Lightning-AI/lightning-thunder/tree/uniform_rng)):...
Hi @mruberry , could you take a look for review
Hi @nikitaved @t-vi , could you help to take a look for merging
Thank you @kshitij12345 ! removing this line works for me
sadly, when this line is removed, there are other cases where a NumberProxy name is returned but it doesn't exist in the trace
> Does this cause any problems in your work? If we have operator that produces NumberProxy results(`unpack_rng_state` in my case), and these results happen to be passed to backward pass(like...
> Wondering what are the other cases that you are looking at? when I remove the treemap line and run the dropout case, it has `NameError: name 'f7' is not...
TODO: fix #231 update the offset according to nvfuser properly
Hi @mruberry @jjsjann123 @IvanYashchuk , I modified it according our design review discussion, could you take a look?