Christian Müller comments

Results 322 comments of


                                            Christian Müller

Route caches should be excluded from caches per route

Ah, paging @bwaidelich IMHO that shouldn't happen and I am relatively sure it didn't in the past.

FEATURE: Introduce `package://` stream wrapper to access files outside of resources

I am torn, I see the utility and the use case of course, but I also feel this is... not good. Gives to much random power to people to mess...

FEATURE: Introduce `package://` stream wrapper to access files outside of resources

> I do not consider stream wrappers a security feature. I mean who gets access to them has found a way to access the file system in the first place....

FEATURE: Introduce `package://` stream wrapper to access files outside of resources

Thank you so much for trying that (again) I really think I would prefer it that way, sorry for jumping in so late. I would also disallow any write operations.

FEATURE: Introduce `session:collectgarbage` command and move the garbage collection from session to sessionManager

+1 by reading, need to test this still.

BUG: @apply converts null to empty array() in certain cases (since update to Neos 8.0)

This is the reason I am against such conditional changes of behaviour (as we discussed for @if and process), I am not a fan of the DataStructure magic either. What...

FEATURE: Custom label for auto created child nodes

See inline comment 👎 for now

FEATURE: Custom label for auto created child nodes

👍 Shoudl be fine!

FEATURE: Custom label for auto created child nodes

I re-read the code and from a user perspective this is great, but I am still not convinced about the implementation. That's a lot of logic in the LabelGenerator that...

TASK: Improve NodeContentDimensionsInformation partial

@dfeyer woudl you vote yourself, then we can merge IMHO