Christian Müller
Christian Müller
I am not quite sure what the state is here, I guess this still needs some work?
> > I am not quite sure what the state is here, I guess this still needs some work? > > The state is, that I will focus on it...
Sorry for being late, but the proposed behavior looks good 👍 Thanks a lot. Will try to get a full review done as well.
I would like to add the amount of first time contributions. That's something I would want to know over time.
IMHO the conclusion should be that NodeTypes shouldn't be a top level folder but reside in `Resources`, allowing all access to package resources seems like an anti-pattenr. We wouldn't want...
> the folder already exists and works for nodetypes config: I know, I am saying it was not a good idea to put it there. (Note, hindsight obviously, at the...
> Actually i like that NodeTypes is first class citizen in Neos-packages as this is the main thing integrators have to adjust. However this should be discussed elsewhere. And I...
But then you also need to include tags and lifetime to the hash (and tags might be in different order), otherwise it will become impossible to "change" lifetime or tags...
Wait, wait. First of all why the heck do you have query arguments in your uriPattern? That is a bad idea and secondly I am pretty sure exceedingArguments are not...