Kit Choi

Results 76 comments of Kit Choi

Ah, a simpler grammar file would also reproduce this: ``` start: item item: "a" ``` But the differences occur less often.

Closing via https://github.com/enthought/enable/pull/403

@fred4ets Thank you very much for trying the source. Sorry that https://github.com/enthought/enable/pull/403 did not fix the problem. May I ask which `scatter.py` file you try and what packages did you...

Thank you very much @fred4ets. This will be looked into.

Thank you @seratch for your prompt response. In case this helps, I was able to reproduce a similar silent failure by deliberately supplying a channel ID that does not exist:...

I believe Traits is already dropping Python 3.5, which means we can use descriptors with `__set_name__` to do things that used to require metaclasses. If I understand the intention here,...

I am a bit confused about this issue. Is this related to the behaviour that TraitsUI editor factory _always_ fall back to a text editor when any import fails? https://github.com/enthought/traitsui/issues/864

This may be where the pain comes from: https://github.com/enthought/traitsui/blob/fb8ea4a4e7df575a707e64cae8eb882a68ef995c/traitsui/editor_factory.py#L224-L227 This line is probably raising ImportError, which then get captured by the block above https://github.com/enthought/traitsui/blob/fb8ea4a4e7df575a707e64cae8eb882a68ef995c/traitsui/qt4/code_editor.py#L30

I think there are probably many tests like this. On CI, `etstool.py` sets an environment variable: https://github.com/enthought/pyface/blob/92ab7363268ddcf9efde8fc4cdc561b042160e90/etstool.py#L294-L299 which gets used in `load_tests` for filtering test suites during `unittest discover`: https://github.com/enthought/pyface/blob/92ab7363268ddcf9efde8fc4cdc561b042160e90/pyface/__init__.py#L69...

In this PR that introduces GitHub Actions to TraitsUI, the environment variable is made redundant: https://github.com/enthought/traitsui/pull/1415 I just noticed that the recipes for building EDM eggs also have to set...