kitcatier

Mark black_box function as unsafe

1

Hello, I found a soundness issue in this crate. https://github.com/bluss/bencher/blob/8afeeb1ccf7d9f58764a343a0099e140703ad287/lib.rs#L590-L596 [https://doc.rust-lang.org/std/ptr/fn.read_volatile.html](url) The unsafe function called needs to ensure that the parameter must be : - src must be valid for...

Mark init function as unsafe

3

Hello, I found a soundness issue in this crate. https://github.com/rasendubi/bkernel/blob/521e10000b3297274b4ba9fa0abdd221df3c87f1/stm32f4/nvic.rs#L113-L130 It is not a good choice to mark the entire function body as unsafe, which will make the caller ignore...

https://github.com/twilco/kosmonaut/blob/db1595ab48f40ce3a11014ebd440284ca6e81148/components/gl/src/viewport.rs#L4-L8 Hello, it needs to be marked as unsafe to ensure correct use and make the caller aware of the risks. It is not a good choice to mark the...

https://github.com/ihalila/pancurses/blob/274e270588d4f3fda2332179796b741a110d893a/src/unix/mod.rs#L20-L22 Hello, this function needs to add the unsafe keyword, because it calls another unverified C function wattron, which is an unsafe operation.. It is not a good choice to...

https://github.com/koute/stdweb/blob/9b418d98df6fafaa4d4b87b04c304d0220292055/src/webcore/global_arena.rs#L69-L76 hello, if a function's entire body is unsafe, the function is itself unsafe and should be marked appropriately. Marking them unsafe also means that callers must make sure they...

## Description Please describe the PR here. ## Pre-Submission Checklist When you submit a PR, please make sure your PR satisfies the following checklist: - [ ] I assert this...

mark freeze_expr function as unsafe

1

https://github.com/gluon-lang/gluon/blob/27cec6c8ef90de7341d22a2beeade532680aa40c/vm/src/core/mod.rs#L602-L614 https://github.com/gluon-lang/gluon/blob/27cec6c8ef90de7341d22a2beeade532680aa40c/vm/src/core/mod.rs#L616-L635 Hi, it is not a good choice to mark the entire function body as unsafe, which will make the caller ignore the safety requirements that the function parameters...

make set_for_current function unsafe

1

##### Checklist - [ ] tests are passing with `cargo test`. - [ ] tests and/or benchmarks are included - [ ] documentation is changed or added - [ ]...

Hello, I found a soundness issue in this crate. https://github.com/bastion-rs/bastion/blob/c6016a95f64965e0b9ae61c18fdfbe3437eef65f/src/bastion-executor/src/placement.rs#L20-L23 Here's a quick example of this issue: ```rust extern crate bastion_executor; use bastion_executor::placement::CoreId; fn main() { let a:CoreId = CoreId...

https://github.com/DaGenix/rust-crypto/blob/cc1a5fde1ce957bd1a8a2e30169443cdb4780111/src/util.rs#L32-L39 Hello, if a function's entire body is unsafe, the function is itself unsafe and should be marked appropriately, which will make the caller ignore the safety requirements that the...