Sergii Dymchenko

Results 27 issues of Sergii Dymchenko

Currently lint jobs are re-run even if it's an actual lint failure, because `step.name.toLowerCase().includes("(nonretryable)")` doesn't work since moving to Nova. This PR proposes a simplification of the logic - never...

CLA Signed

See https://github.com/pytorch/pytorch/issues/125050 for details. This will require passing file path as an input to the rules. In general it doesn't make too much sense, but for PyTorch-internal rule like TOR901...

enhancement

As described in https://github.com/pytorch/test-infra/pull/4559#discussion_r1319881628 It will be just a linter, not a codemod, as it's not possible to determine the desired value statically.

good first issue
new check

Add a doc (probably just part of README) listing all available error types with codes and explanations. Then add a test that the doc has the info for the error...

documentation

TorchFix should understand statically types of the objects. This feature will enable more rules and more precise targeting for the existing rules. The implementation will require adoption of Pyre and...

enhancement

Currently TorchFix tries to follow latest PyTorch main for things like deprecated APIs. This is not ideal for people who want to use a specific release, for example. So every...

enhancement

`torch.load` without `weights_only` parameter is unsafe. Explicitly set `weights_only` to False only if you trust the data you load and full pickle functionality is needed, otherwise set `weights_only=True`. If `weights_only=True`...

Add documentation for the rules to the https://github.com/pytorch-labs/torchfix/blob/main/README.md, see the existing file for examples. If you what to work on a task, please comment on this issue and link your...

documentation
docathon-h1-2024
easy

For many ops `dtype` parameter can be provided, and it should be preferred (from readability and performance point of views) to use it instead of converting the op results to...

new check

Tested via CH UI.

CLA Signed