torchfix icon indicating copy to clipboard operation
torchfix copied to clipboard

Feature needed: TorchFix should understand statically types types

Open kit1980 opened this issue 10 months ago • 0 comments

TorchFix should understand statically types of the objects. This feature will enable more rules and more precise targeting for the existing rules. The implementation will require adoption of Pyre and LibCST’s TypeInferenceProvider. The feature will likely be optional as running Pyre may be a barrier for some users.

As an example, currently TorchFix will understand that this qr is a deprecated function here:

import torch
torch.tensor([[1.0], [2.0]])
torch.qr(a)

But not when using method notation - a.qr() - because TorchFix doesn't understand statically that a is a PyTorch tensor, maybe it's some unrelated object that just happens to have a method named qr.

kit1980 avatar Apr 13 '24 00:04 kit1980