Kyle Into

> > but then the bigger question of "how do we sort these correctly" is still unanswered.... I'll comment on the original task for that > > This is also...

> @kinto0 Is there anything left to do here? If possible I'd like to avoid future merge conflicts 😄 sorry!!! not sure how I missed this. I swear I imported...

> > could you paste the test failure? it should show the messages back/forth. > > ``` > running 1 test > client--->server {"id":1,"method":"initialize","params":{"capabilities":{"textDocument":{"publishDiagnostics":{"codeDescriptionSupport":true,"dataSupport":true,"relatedInformation":true,"tagSupport":{"valueSet":[1,2]},"versionSupport":true}},"workspace":{"configuration":true}},"clientInfo":{"name":"debug"},"processId":64851,"rootPath":"/","trace":"verbose"}} > client client--->server {"method":"initialized","params":{}} > Reading...

bumping some old PRs: if you still want a review on this, please re-request review

@dearfl it looks like a bunch of tests are failing. would you be able to investigate this?

looks like a deadlock! I think we need to drop the lock on version_info in text_document_did_change before calling validate_in_memory_and_commit_if_possible. otherwise, both calls will be fighting for the lock.

what's the size of the largest file you're having pyrefly analyze? it seems like we're ooming trying to send semantic tokens, which only operate on a single module. maybe we...

is the workspace you are using public enough for me to reproduce it locally?

one easy thing to test might be disabling semantic tokens through the configuration. if this doesn't crash it, that's a hint that we're on the right track (in user settings,...

weird... we might need more vscode expertise here. does this happen with any other extensions? it might be worth creating an issue [here](https://github.com/microsoft/vscode/issues) to see if there's any extra telemetry...