Kyle Into
Kyle Into
Thanks for all the debugging steps @DanielNoord! Thanks to your investigation, I think I have a fix ready [here](https://github.com/facebook/pyrefly/pull/1730). I also think [this](https://github.com/facebook/pyrefly/pull/1731) could fix the flaky test_pythonpath_change
@cybardev can you confirm whether these tests are still flaky? I haven't seen these tests fail recently since the fix. but I do see some other ones (test_exit_without_shutdown, test_connection_closed_server_stops) fail...
> Interesting... Seems that it fails on darwin too: https://github.com/cybardev/nixpkgs-review-action/actions/runs/20086697819/job/57625825916#step:6:1 > > For some reason it works on my machine... I wonder if it's something to do with Nix's sandboxing....
> * pyrefly/lib/state/lsp.rs not sure exactly what the conflicts are but it says there are conflicts in pyrefly/lib/state/lsp.rs. if you pull + merge, it should tell you. let me know...
looks great now! thank you for working on this
> @kinto0 is there any update sorry about the delay. we've been taking some time off with the holidays and I haven't got a chance to get through my backlog....
Thanks so much for the report! I'll try to get to this on monday. But feel free to take a stab at it in the meantime if you want since...
thanks for the detailed report!! I think both issues should be fixed by switching to a textedit based completion response for literals instead of relying on client interpretation of `inserttext`....
current status: - quotes are still duplicated on acceptance of completion
hi @Karman-singh15 please reopen the PR if you would like to continue working on this