Iraklis Psaroudakis
Iraklis Psaroudakis
We briefly took a look at this with @tlrx . We saw there is a [`cluster.remote..transport.ping_schedule` setting](https://www.elastic.co/guide/en/elasticsearch/reference/8.3/remote-clusters-settings.html) that defaults to -1 because of TCP keep-alives. But even this setting might...
Hi! @DaveCTurner , because @henningandersen may see this later , I added you as reviewer because I noticed your name in several tests I modified; please tell me if you'd...
Hi @DaveCTurner , I get you. I also thought of this problem in the last couple of days. I was mostly working on the tests so that they are comprehensive,...
Hi @DaveCTurner , that makes sense, it is a very tight window until FF. No problem, please review when you can, and indeed I will make it compatible as/if needed...
Thanks for the tips @DaveCTurner ! If one LGTM is enough, I believe I could disengage you & Henning, and ask @gmarouli if you would be comfortable to review this,...
> @kingherc , honestly I am not comfortable enough being the primary reviewer for this change. I have gained some knowledge lately on the watermarks but it is still pretty...
Deployed on ESS and turned healthy without any log mentions of `headroom`.
Carved out the disk usage double rounding issue into separate PR: https://github.com/elastic/elasticsearch/pull/88683 . Merged and this PR now is lighter.
Thanks @gmarouli for the review so far! Please note that as @DaveCTurner requested, I extricated the part related to converting the disk watermarks to RelativeByteSizeValues to another PR at https://github.com/elastic/elasticsearch/pull/88719...
> > I am thinking of whether I should do anything with this PR. Maybe rebasing it on top of the other PR. > > Once #88719 is merged to...