Taehyun Kim
Taehyun Kim
@dsmith3197 Yes, this could break those container port related templates, but I think adding all those additional values for container ports will make this pr too large
@dsmith3197 Is this ok?
@jszwedko I just wanted to fix the [broken tpl config](https://github.com/vectordotdev/helm-charts/blob/develop/charts/vector/templates/configmap.yaml#L11). Also, templating in string config let you handle different configs in single template. as I mentioned [above](https://github.com/vectordotdev/helm-charts/pull/346#issuecomment-1837847346). Using list or...
@jszwedko Sorry, I was confused the context as it's 4months old. The original intention was to support string type `customConfig` because it's the best way to utilize tpl. In current...
The code `{{ tpl (toYaml .Values.customConfig) . | indent 4 }}` converts the yaml to string first, and then runs the `tpl` function. That means `{{ if eq .Values.favorite.drink "coffee"...
@jszwedko I've just read helm documents. `tpl` function generates string output, and `toYaml` function converts key-value map to string in yaml format. `tpl` can't be run before `toYaml`. `toYaml` should...
@jszwedko Hi, `toYaml`'s input is object and `tpl` consume and produces string, so it's not possible to run `tpl` before `toYaml`. Can we merge this?
/remove-lifecycle rotten
I want this feature too. This PR doesn't look adding default lifecycles to existing workloads, just provide a way to configure it. @zyyw Is there any concerns or point to...