Alexey Kucherenko

Results 32 comments of Alexey Kucherenko

@vincentpham13 Yes it works. You need to pass custom `authenticateHandler` to authorize handler or make sure there is authentication exists. Please go though this stuff https://github.com/oauthjs/node-oauth2-server/issues/358 https://github.com/oauthjs/node-oauth2-server/issues/264 There is an...

Our team will work with this package a little bit more. I'd like to write tests to be sure that functionality work. So, please do not close this PR, I...

@TheWisestOne Thank you for letting me know about the issue. I think I will patch the lib on the week-end to make sure that the case `data:application/json,{"key":"some value"}` will work....

@fregante The regex of [valid-data-url](https://github.com/killmenot/valid-data-url) seems doesn't handle it correctly. I will fix it next week. Thanks.

if anyone could do a PR for that I will be happy to merge

@strarsis Please test this version: https://github.com/killmenot/parse-data-url/tree/browser-support and let me know how it works

@strarsis does it work as planned? Have you had a chance to test it?

@strarsis parseDataUrl requires [valid-data-url]( https://github.com/killmenot/valid-data-url) to work correctly. See [here](https://github.com/killmenot/parse-data-url/blob/browser-support/index.js#L6-L15). If it's not defined it [throws an error](https://github.com/killmenot/parse-data-url/blob/browser-support/index.js#L18) However, even if I include `valid-data-url` in your pen still doesn't work...

@bahadirarslan Hello, unfortunately have no time to add this to the library but if someone make a PR, I will consider and merge it

I will back with the reference / test data soon (later this week). Had no time to dig to it before