Pascal Hertleif

Results 223 comments of Pascal Hertleif

@wildarch I'm slightly confused (maybe I just need more coffee) -- what is MyProtoMessage here? A message or a custom type for representing the structure of proto messages? Can your...

Heh, using `grep '^{'` is pretty clever! I'll be doing that! > How do you think the error recovery should work? I would not "recover" anything :) I haven't looked...

Sounds good. Thanks for your quick replies, the grep, and the far nicer rq code! :)

I'd call it `#[diesel(skip_deserializing)]` to be similar to serde. And we should probably only allow that for fields whose type implements `Default`.

> What I was searching is a way to totally ignore that field in the database. That means, Diesel to load (in that case) always None in the author field....

@toddWannaCode that's absolutely fine! Most PRs are quite isolated in scope so you don't need to know everything beforehand. :) Feel free to have a look at and review PRs...

Absolutely! Want me to add you to the Reviewers team? Evan Cameron schrieb am So. 24. Sep. 2017 um 23:22: > I'd be interested in jumpiing into some code reviews,...

@toddWannaCode, welcome to the league of extraordinary reviewers! :)

@leshow, welcome to the ~~Four~~ Nine Horsemen of the Code Review!

@ecasilla, thank you for joining the Order of Magnitude!