diesel
diesel copied to clipboard
diesel-rs
More code reviewers wanted!
With the push to 1.0, the current pool of reviewers is starting to run low on bandwidth. We're looking for more people to help get involved with code review. You don't need to be familiar with Diesel's internals to help. Most people who have been on the Diesel core team got started by doing code review. If you're unsure what a piece of code does or why it's being done a certain way, just ask! (Make sure that the commit message doesn't answer that question already though). Don't feel like you can't ask a question just because other reviewers might already know the answer. We're happy to help you get up to speed.
Nice. Is the best way to get started to just review and add comments/questions to PRs?
Yup. If you'd like I can add you to the github group which gets pinged for code review
I am really interested in this but I am just getting started with diesel.
@toddWannaCode that's absolutely fine! Most PRs are quite isolated in scope so you don't need to know everything beforehand. :) Feel free to have a look at and review PRs to get a feel for it, and if you like it, ping me (or another core team member) and we'll add you to the reviewers team.
I'd be interested in jumpiing into some code reviews, if you folks are still looking for people.
Absolutely! Want me to add you to the Reviewers team?
Evan Cameron [email protected] schrieb am So. 24. Sep. 2017 um 23:22:
I'd be interested in jumpiing into some code reviews, if you folks are still looking for people.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/diesel-rs/diesel/issues/1186#issuecomment-331741068, or mute the thread https://github.com/notifications/unsubscribe-auth/AABOX5OL_jjKy7inV3oLryKG0EqflFLaks5slsgOgaJpZM4Pf3MF .
Hey I would be like to be a member of the Reviewers team. Thanks. @killercup
@killercup How will the mentoring work exactly is there a gitter for the core team?
@ecasilla You can ask questions either in the public gitter or as comments on the PRs you're trying to review (feel free to ask questions after things have been closed/merged as well)
I'm a bit late to the party and I haven't really gotten a chance to use diesel, but I'm trying to get into Rust more and would love to help with reviews!
@retep007 I've added you to the team -- You'll get pinged on future PRs, but feel free to review any of the open PRs in the mean time. There's quite a few open right now.
(Note: Everyone who's replied to this has been added shortly after replying, I'm only singling that person out because there happens to have been an extremely high volume of PRs opened in the past 24 hours and I assumed the were around right now)
I should also mention -- If anyone tries to review a PR, and feels like they don't understand enough to properly review it, please ask questions on the PR. We don't mind explaining things that aren't clear, and hearing what needs more context before the PR is opened is extremely helpful.
Hello all, is there any chance I could please be added also? I am however very much a beginner with Rust :)
Hey folks, just a heads up, I did some cleanup tonight. Anyone who hasn't commented on an issue in the past month will have been removed. If you'd like to be re-added, please comment again on this issue.
Hi @sgrif, let me help you with reviewing! Diesel is used in my work, so improving Diesel is also important task.
I would like to do some code review work! It's been lots of fun using Diesel, and I would like to get a good grasp of the internals.
@AlterionX I've added you to the corresponding team. You should now get notifications on requested reviews. Feel free to ask questions everywhere where something is unclear.
Hi! I would like to be added as a reviewer. I'm not familiar with Diesel internals, but I know Rust and would like to help and learn :)
@Razican I've added you to the corresponding team. You should now get notifications on newly requested reviews. If you want you could also check existing PR's. Feel free to ask questions anywhere where something is unclear, we will try to explain it :wink:
If you don't want to be at the reviewer team any more at some point of time just tell us that and we will remove you from the list that get's pinged on new PR's.