Lauri L

Results 10 comments of Lauri L

@ntadej , I see that you have submitted CMake changes for Qt6. I have been working on [porting QtLocation to Qt6](https://bugreports.qt.io/browse/QTBUG-96795). Majority of the work is already done. Mapbox GL...

Nevemind, gentelmen, I got it working! @ntadej , you plugin is based on Qt 5 but I was having troubles on Qt 6. Now, if you take this: https://codereview.qt-project.org/c/qt/qtlocation/+/382087 It...

> MSVC works for me in Qt5 though. I never updated the plugin to Qt6 as the infrastructure was not there. Yes, of course. Now luckily it's almost ready. And...

> I have a Qt5-based MSVC 2019 CI running here if interested: https://github.com/ntadej/qt-geoservices-maplibre/actions/workflows/CI-Windows.yml Thank you! I will definitely have a look at it next week. I didn't know that you...

Now, when building with MSVC 2019 and Qt 6, I have to apply two things. 1. Set the same exception handling compiler flag as Qt 6 does: ``` if(MSVC) target_compile_options(mbgl-core...

@ntadej , I renamed the old MapboxGL plugin and made a push to [Qt Gerrit](https://codereview.qt-project.org/c/qt/qtlocation/+/382087) but now we reach the point where we could cooperate. Maplibre itselt is in the...

> I read the Gerrit changeset quickly and I wonder if having the plugin decoupled from the Qt releases might actually be a good idea so it does not have...

Windows MSVC debug build has a pretty bad performance. Release or RelWithDebug is nice and smooth.

I recommend to switch to Qt6. There is a patch that builds also on MSVC 2019 in [here](https://codereview.qt-project.org/c/qt/qtlocation/+/382087), with the exception that one Boost library bug has to be applied....