Jerome Kieffer comments

Results 408 comments of


                                            Jerome Kieffer

Add `python_requires` to setup

`setup.py` is gone

Possible memory leak when collecting events for profiling

Here are the `valgrind` "massif" profile for two calls of the program when running on a limited number of images (2000), with and without profiling activated. Valgrind still suggests to...

Possible memory leak when collecting events for profiling

I run it several other times and it looks like the profiling in OpenCL prevents the memory from being freed.

Possible memory leak when collecting events for profiling

So I tired to collect only timestamps for each event instead of the complete process. The patch is for now implemented in: https://github.com/silx-kit/silx/pull/3690 The memory profile looks like this, now....

Possible memory leak when collecting events for profiling

I got struck by something similar in another project ... but profiling was not involved this time. https://github.com/kif/multianalyzer/blob/main/multianalyzer/opencl.py The pattern was similar: read data from an HDF5 file with large...

[OpenCL] Better graphs for profiling results ...

Issue: what if the number of calls to the kernel differ ... use NaN ?

make match ratio configurable in opencl/sift

One should document this new environment variable ... beside this, the code LGTM

[2.0.0][OpenCL] issue with pocl 5.0.2 -- help :)

Tested on PoCL 3, 4 and 5: # POCL3: OpenCL 3.0 PoCL 3.1+debian Linux, None+Asserts, RELOC, SPIR, LLVM 15.0.6, SLEEF, DISTRO, POCL_DEBUG ``` lintaillefer:~/workspace/silx % PYOPENCL_CTX=portable POCL_DEBUG=all POCL_WORK_GROUP_METHOD=cbs ./run_tests.py src/silx/image/test/test_medianfilter.py...

[2.0.0][OpenCL] issue with pocl 5.0.2 -- help :)

I managed to get it crashing with: `OpenCL 3.0 PoCL 5.0 Linux, Debug+Asserts, RELOC, SPIR, SPIR-V, LLVM 16.0.6, SLEEF, POCL_DEBUG`

[2.0.0][OpenCL] issue with pocl 5.0.2 -- help :)

So the regression appears to be more in LLVM than in PoCL ...