silx icon indicating copy to clipboard operation
silx copied to clipboard

make match ratio configurable in opencl/sift

Open ChannyClaus opened this issue 1 year ago • 4 comments

resolves https://github.com/silx-kit/silx/issues/4098

allows the users to configure match ratio via the environment variable SILX_SIFT_MATCH_RATIO. should be a pretty low-risk + perfectly backwards compatible change.

ChannyClaus avatar Apr 03 '24 18:04 ChannyClaus

One should document this new environment variable ... beside this, the code LGTM

kif avatar Apr 09 '24 08:04 kif

An environment variable doesn't seems to be needed here.

Since silx.opencl.sift.param.par is a dict, it is possible to change the value programmatically:

import silx.opencl.sift.param

silx.opencl.sift.param.par["MatchRatio"] = 0.5

t20100 avatar Apr 09 '24 09:04 t20100

An environment variable doesn't seems to be needed here.

Since silx.opencl.sift.param.par is a dict, it is possible to change the value programmatically:

import silx.opencl.sift.param

silx.opencl.sift.param.par["MatchRatio"] = 0.5

ahh darn great point. let me close this. thanks! should we document this?

ChannyClaus avatar Apr 09 '24 12:04 ChannyClaus

should we document this?

Yes, Pull Request welcomed!

t20100 avatar Apr 09 '24 15:04 t20100