Ryan Kienstra

Results 17 issues of Ryan Kienstra

**Request For Code Review** Hi @delawski, Thanks a lot for your solution for the [plugin issue #1109](https://github.com/Automattic/amp-wp/pull/1109). Could you please review this, when you have a chance? @westonruter noticed an...

* When a test fails, this adds a base64 screenshot of the browser * When a simple selector like `.foo-bar` fails, this suggests an alternative class or id that works...

* Use TypeScript for non-test `.js` files * Add a `jest.config.js` so the Jest tests pass * Update `.eslintrc` so ESLint passes

* Ideally, get a lot of the benefits on TypeScript, without the need to compile. * Inspired by https://www.hackernoon.com/why-i-no-longer-use-typescript-with-react-and-why-you-shouldnt-either-e744d27452b4

* Use `getByLabelText` and `getAllByText`. * Also, use `wait-for-expect`.

* Experiment with using [Enzyme](https://airbnb.io/enzyme/) instead of [React Testing Library](https://testing-library.com/docs/react-testing-library/intro) * This seems to be very similar, but maybe because these tests are simple * These are trivial changes *...

* Try testing via [ReactDOM.render()](https://reactjs.org/docs/react-dom.html) instead of [React Testing Library](https://testing-library.com/docs/react-testing-library/intro) * Not very different from React Testing Library, but its helper methods were nice * Added a helper method `hasTextContent()`,...