kiblik

Results 18 comments of kiblik

# TL;DR: Check `'default'` and `suffix` ```python @swagger_auto_schema( method='get', responses={'default': serializers.DeletePreviewSerializer(many=True)} ) @action(detail=True, methods=["get"], filter_backends=[], suffix='List') ``` # Long version Hi @tfranzel, - I disagree with this statement: _`detail=True` only...

Hi @sscarduzio, Do you publish somewhere hashes of ZIPs of the plugin? Like SHA1 in the email or like SHA512 on ES website. I would like to check hash after...

@xoda, I check the actual implementation. The part responsible for pulling data is here https://github.com/DefectDojo/django-DefectDojo/blob/dc20ee1bf9f99953b50c610bd9840053e8fd12f1/dojo/tools/sonarqube_api/api_client.py#L38-L53 Except of other parameters processed in the function [`SonarQubeAPI.import_issues(test)`](https://github.com/DefectDojo/django-DefectDojo/blob/master/dojo/tools/sonarqube_api/importer.py#L75), response from the API contains also...

> After looking better at SQ documentation, the API is there, but is marked as _internal_, stating: > > `Use at your own risk; internal services are subject to change...

@lmenezes `HTTP-auth-proxy:443 (kerberos authentication - pass 'authorization' and add 'x-forwarded-...')` -> `cerebro:9000` -> `ES:9200` Is it understandable?

I know, this is already merged but I also suppose there should not be able easily to change the product for engagement. There is high chance, that `Engagement` contains `Test`....

@Gby56, sorry for the delay. I wrote my comments. I'm a little bit confused that some of them haven't been identified by Flake8

Ouuuu, sorry @coheigea & @Gby56. 6 days ago, I wrote my comments but I forgot to click "Submit Review" so they haven't been visible to everybody and they stayed in...

Yes @Gby56, it looks good to me. Thank you for the changes and your effort. Unfortunately, I do not have "approval" or "merge" rights here, so you will need to...