Igor Savin comments

Results 605 comments of


                                            Igor Savin

Validate if a rewrite in TS has any performance penalty

I am happy to write benchmark for this task, but not sure when I'll find time for it

Validate if a rewrite in TS has any performance penalty

I am generally curious where this might go and especially curious to see perf implications of this change. let's not close it just yet. I'll contribute what I can

Validate if a rewrite in TS has any performance penalty

@Fdawgs isn't that the other way around? if TS doesn't cause perf regression, it should be the way to go due to the increased simplicity of the maintenance?

Validate if a rewrite in TS has any performance penalty

@jsumners 1) You don't need to remember to manually sync types, they are always perfectly accurate; 2) You catch more stuff at compilation/linting time Assuming that TS types already exist...

Validate if a rewrite in TS has any performance penalty

@Uzlopak Should there be any? See the original description: `Maintaining types is hard and error-prone. I opened this issue to make an experiment if a rewrite of this module in...

Releases on Github out of sync with actual releases?

@cressie176 I think I may have permissions to setup secrets. let me check if I can add them to you too

Fix pop-value being sent for undefined values.

@lights-a5 Can you check if your tests are correct in this case? maybe they were checking that the wrong behaviour is wrong and actually need to be adjusted

Fix typescript export

@xfournet Can you please add some kind of a test for this? e. g. via https://www.npmjs.com/package/@arethetypeswrong/cli

Passing a number will allocate a Buffer the size of the number

@Orel-A PR to fix it would be welcome!

Should testing style be changed?

Is there a difference in IDE support for these two options? If unclear, I can do a quick test