Igor Savin comments

Results 605 comments of


                                            Igor Savin

Windows Authentication Support

@hrmartinez Should be fairly simple to build an official knex dialect out of this, extending existing mssql one. Would you be open to send a pr for this?

knex where is not escaping field objects with mysql engine (potential SQL injection?)

Unfortunately, I do not currently have time for a quick fix; I can look into this in January; or review any fixes that community might provide.

knex where is not escaping field objects with mysql engine (potential SQL injection?)

@rgmz I didn't receive any communication from your side via email or twitter, could you please confirm which communication channel did you use? I did have a brief exchange with...

knex where is not escaping field objects with mysql engine (potential SQL injection?)

Fix was released in 2.4.0, please validate.

Performance is remarkably slower when passing bindings to query

can you test the same with sqlite to see if it is db-specific?

QueryBuilder not working in Typescript

Your TS version is too old

stream.end() does not return connection to pool - race condition

This should have been addressed in 0.21.3. Additional testing and feedback would be most appreciated.

Customize connection pool and/or queries for cluster instances

I'll finally create a separate repo for knex-related utilities today, so if anyone would volunteer to build solution similar to the one proposed above, it could be included there. It...

Updated sqlite3 and better-sqlite3 to use more accurate numeric types

@mohammedbalila integration2 has the modern structure for tests, it is the one that should be used. we probably should rename the other one

Updated sqlite3 and better-sqlite3 to use more accurate numeric types

@mohammedbalila it's fine, next version is semver major anyway