Igor Savin

Results 605 comments of Igor Savin

@SkeLLLa None of the CI errors seem to relate to changes in the PR. Do builds work on main OK?

Update: https://github.com/SkeLLLa/fastify-metrics/pull/95 is passing, so this is something that I broke. Will check.

sure, if current version doesn't work, will use named arrow functions!

@SkeLLLa problem with `const namedArrowFunction` is that this approach requires making quite a few FastifyMetrics fields/methods to become public :-/. Wonder if there even exists a good solution here.

@lehni If you want to get ARM support with MySQL, you can either use a sufficiently new version (I think it started working around 8.0.34 or a bit earlier), or...

#67 this fixes the issue reported, hopefully it gets merged at some point and a new version gets released.

If accepted, we could send a PR.

> a factory function option that gets cached as we do with other things of this nature @jsumners Can you point to any part of existing code that does this?

`It would remove the function invocation cost at every request and make it a symbol lookup.` How would that work if we may need to dynamically recalculate the message for...

I mentioned that it would make sense to incorporate request details, otherwise not much benefit over original