Kian Molani
Kian Molani
> Can you add the `connectors` in the doc strings as well? And name the states `s(t)` to be consistent with the rest of the library. > > If you...
> I meant a `# Connectors:` section in the doc strings, listing the connectors of the components. You can have a look at the doc strings in the other modules....
There appear to be issues with our simulated results for a mass-spring-damper model. Julia and Modelica simulation results do not match, and the difference is very apparent. I've attached below...
> Could the difference between julia and modelica lie in the initialization? Is there a difference already at the first point saved in the solution? I believe that they've been...
> Let me see if I understand this correctly, the fixed point is at `s = 4.5` and the spring has resting length `s_rel0 = 1`, then I'd expect the...
Indeed, I've just confirmed that setting the spring length to 1.5m in our Julia simulation in order to account for this "gap" yields matching simulation results.
Perhaps mass length is a property that we should include as well.
> You should remove `.vscode` and `.DS_Store`, then the PR is good to go after formatting. All `.vscode` and `.DS_Store` files have now been deleted.