Kian Eliasi
Kian Eliasi
I found the issue and hopefully fixed it but I couldn't find the documentation entry, perhaps because `popitem` is not implemented explicitly in the code. Is there any way to...
@nateprewitt do you mean just making the inherited methods work for now? They're currently ok other than `popitem` which the PR fixes.
I raised PRs for DBSCAN, Birch and MDS, respectively #23590 , #23593 and #23593 In the DBSCAN PR, it seems that [the mypy check is failing erroneously](https://dev.azure.com/scikit-learn/scikit-learn/_build/results?buildId=43124&view=logs&j=32e2e1bb-a28f-5b18-6cfc-3f01273f5609&t=f370d024-dfa6-536d-2b2d-766ea2a2900c) and I couldn't...
@reshamas I think using `"boolean"` constraint is kinda mandatory. The constraint was written to include np.bool_ in addition to the native bool type. ([more info](https://github.com/scikit-learn/scikit-learn/pull/23618)) I'm having problems with mypy...
@mpl I totally agree with you. However in the issue it was said that the retry middleware should log aborts with debug level (just like recovery) and that's what I...
> I suggest not retrying on this error and just catching the error inside the `recovery` middleware. @ldez so you mean removing the recovery routine inside retry middleware (because it...
Hi. Any plans for reviewing the PR? I was really excited to see it merged.