Khor Shu Heng
Khor Shu Heng
@brills I created the generate_statistics_from_parquet method, based on the conversion function added to tfx_bsl: https://gist.github.com/khorshuheng/4e0d305463a0cd5a5f7600706d619660 To verify the correctness, i compared the statistics generated from the above method, with `generate_statistics_from_csv`....
@brills Thanks for the clarification. In that case, can i submit a pull request based on github gist which i submitted? Or is there more work which is required?
Based on my current understanding, the websocket service API and the cloud server API share most of the code under `biz` crate. As such, if we are to move the...
> Once services/realtime is deployed as a separate service, it will focus solely on message passing. Noted. Does that mean migrating only the realtime client actor to services/realtime, then connect...
The proposed changes seem reasonable to me. I will come out with a draft PR based on this architecture, then we can perform further test on it.
Thanks, https://github.com/AppFlowy-IO/AppFlowy-Cloud/pull/453 does simplify the implementation and makes it easier for me to test the functionality. I have updated my current work accordingly.
> Hi @khorshuheng. It seems like you didn't pull the latest main branch code. Because I saw appflowy-collaborate is different from the main branch Noted, I have probably missed some...
Since docker compose dev doesn't use nginx at all, we can omit the change for dev.env. For port 443, in practice, most users are going to use an nginx instance...
> Looks like this is now available via #776, I think this PR can be closed now? Yes, I will close this now.
Current state: - The ws connection tests passed. - Unable to pass the collab test at the moment. Currently, the get collab endpoint is served by the Appflowy cloud service...