Karl Heinz Marbaise

Results 134 comments of Karl Heinz Marbaise

Why not using `maven-dependency-plugin:analyze` ? What is the difference?

Sorry for the late response... my personal opinion is this is sufficient. Yes... but I'm not a lawyer...

Which version of versions-maven-plugin do you use?

So I've checked that scenario. ``` example (master)$ mvn org.codehaus.mojo:versions-maven-plugin:2.7:use-latest-versions [INFO] Scanning for projects... [INFO] [INFO] ---------------------< com.soebes.exmaple:example >--------------------- [INFO] Building Test 1.0.0-SNAPSHOT [INFO] --------------------------------[ jar ]--------------------------------- [INFO] [INFO] ---...

First I would say not defining plugin versions in pluginManagement is not the best but on the other hand this could be improved ...

@davewichers You should use a more recent version of maven-war-plugin cause this version you are using is about six years old...The most recent version 3.2.2 uses the most recent version...

It would be great having a unit/integration tests to check the behaviour...

It's great that you created pull request but unfortunately you should make a separate PR for each JIRA you are trying to solve....also squash your commits into a single commit...that...

Have you taken a look in the apache maven projects? We use single commit setup and don't want to merge a number of 2-n commits into the history to fix/add...