KhloodElhossiny

Results 9 comments of KhloodElhossiny

Hi! I read the previous discussion here and would like to contribute by investigating and trying to fix it. Please confirm if this is a good first issue to work...

@gregmarr Yes, I understand that `string_view` is supported through the existing template function, and the issue arises with js[Bar{}] due to ambiguity between the two overloads, causing the compiler to...

> > My idea is to add specific string_view overloads for operator[] to guide the compiler in choosing the correct one, resolving the ambiguity. > > Okay, that's not what...

> I think a cleaner approach would be indeed to fix `is_usable_as_basic_json_key_type` to also work with string views. Thanks for the feedback! Yes, that makes sense — I will update...

> I was hoping for something that didn't have to name `string_view` directly, but I'm not sure that's possible. > > Another possibility that seems to work and doesn't require...

@gregmarr Can you help me? I’m having some trouble with the CI checks. Every time I push, I get these errors: - Ubuntu / ci_static_analysis_clang (ci_test_clang) - Ubuntu / ci_test_standards_clang...

> IMO, the library supports `std::string_view` as a proper feature already. The issue here is that the object isn't directly usable as a key but requires an intermediate conversion to...

Hi @nlohmann , I've resolved the conflicts and updated the branch. All CI checks should be green now. Let me know if there's anything else needed! _Thanks for the feedback_