Kyle Herock

Results 76 comments of Kyle Herock

@Anidetrix (awesome to see that you're back!) I just rebased this and would appreciate getting it in an upcoming release. The implementation here should be fully backwards-compatible.

These all look great and I wish I could start using these now. I'm working on a Yarn 2 plugin but the dependency graph of these packages is a bit...

👍 Just confirming that these changes work great in a CLI project I'm writing in TS, would really appreciate if these changes made in in soon!

This does look like a bug/missing function in Keycloak's API - here's the method in charge of converting the request representation into the model: https://github.com/keycloak/keycloak/blob/54c1f1b85a34972066e8636b70703e3ac586923b/server-spi-private/src/main/java/org/keycloak/models/utils/RepresentationToModel.java#L506-L597 You can see that it...

Is it a good idea to allow `getEpochTime` to be async? I would prefer that we maintain a way to cheaply obtain the current time. For example, the following seems...

Web locks seem like a more appropriate API to use since we don't have any information to publish between tabs. Also, I have concerns over using the `_userStoreKey` as the...

Page sessions are unique per tab! From [MDN](https://developer.mozilla.org/en-US/docs/Web/API/Window/sessionStorage). > Whenever a document is loaded in a particular tab in the browser, a unique page session gets created and assigned to...

@Badisi thanks for sharing this, I was also seeing a similar error with my Keycloak application and decided to simply disable refresh tokens, but your explanation makes sense. Rather than...

I don't like to argue popularity as the primary reason for choosing one over another, but in this case I do fear that crypto-es doesn't have enough eyes on it,...

@pamapa is there anything else I should include here? I was thinking that a manual workflow trigger for creating a release could be useful.