Matthew Russell
Matthew Russell
I'm confused why there is so much code guarded with `if (_depl != nullptr)`, but as far as I can tell there is no way for `_depl` to be anything...
To follow up here, I see this on all non `uint8_t` enums. First, even with the 3.2.14 generators, to use a non `utin8_t` enum one must still re-run the core...
I created a similar patch for 3.1.20, I was never really happy with it, but maybe we can compare patches. I don't remember all the details right now, but my...
I don't know is this PR is comprehensize enough, I would really appreciate Covesa's opinion on it.
> I'm not sure about this change, given we are inverting the lifetime of the parent object (service_discovery) and the child object (timers). If the timers are causing some of...
(I haven't forgot, just haven't been able to get to this yet)
> General question on this and #653: How is this not caught by compiler warnings or static-analysis evaluation? (We shouldn't have to deal with trivial things like uninitialized variables, right?)...
You beat my PR by one day :) https://github.com/COVESA/vsomeip/pull/655
> Please rebase Rebased to 3.4.10 and forced pushed a tweak to `internal_android.hpp`
It looks like I hit the Windows build error: ``` D:\a\vsomeip\vsomeip\implementation\routing\src\../../configuration/include/internal.hpp(153,46): error C2039: 'uid_t': is not a member of '`global namespace'' [D:\a\vsomeip\vsomeip\build\vsomeip3.vcxproj] D:\a\vsomeip\vsomeip\implementation\routing\src\../../configuration/include/internal.hpp(153,46): error C2275: 'vsomeip_v3::uid_t': expected an expression instead...