Karsten Hassel
Karsten Hassel
including electron update from v19 to v20
We are using `node-fetch` for fetching url's in 3 places: - calendar - newsfeed - e2e tests With the new version v3 they decided to [convert `node-fetch` to ES module](https://github.com/node-fetch/node-fetch/blob/main/docs/v3-UPGRADE-GUIDE.md#converted-to-es-module)...
Previous Versions: If you run `docker-slim build` without param `--http-probe` this meant `--http-probe=false` as default as described in the README. Now: If you run `docker-slim build` without param `--http-probe` ````...
- fix e2e tests (#2911) - ~~disable recurring-event-tests of calendar: I opened a new issue #2913 for this, the tests are failing at the moment and I will enable them...
The modules `currentweather` and `weatherforecast` were already only dummies displaying they are deprecated: "This module is deprecated since release v2.15 and removed with v2.19." So removal was announced with v2.19,...
I'm not sure if this should be merged but I tested this because of these discussions: - https://github.com/MichMich/MagicMirror/issues/3212 - https://forum.magicmirror.builders/topic/18069/multiple-modules-in-a-region/17 With this PR you can - define own module positions...
See discussion [here](https://github.com/MagicMirrorOrg/MagicMirror/pull/3350#discussion_r1451981420). Beside the author headers: Need we in every file the `MIT Licensed` stuff? Any other cleanup wishes?
When debugging another issue I stumbled over the `[DEBUG]` line in the start logs when using default config: ```bash > [email protected] server > node ./serveronly [15.01.2024 20:25.31.730] [LOG] Starting MagicMirror:...
```bash ● Calendar module › exdate check › should show the recurring event 51 times (excluded once) in a 364-day (inclusive) period expect(received).resolves.toBe() Received promise rejected instead of resolved Rejected...
No new problem, our e2e test are failing unrelated to the tested code. Was already discussed in some PR's so I decided to make an issue for this. My observations:...