Kevin Gilbert

Results 14 comments of Kevin Gilbert

Side-bar: I can't believe you actually used the name "crappy" in the function name. Though I suppose it does help differentiate it. Anyway, I'm wondering if this can be cleaned...

I'd _like_ to see if there's a programmatic fix somewhere in the parser code, but worst-case scenario I think we just add some more apostrophe exceptions to the `nameFixes`.

Thanks for confirming it's a data source issue. May I start writing some exceptions into `nameFixes`? ATorri and NDoye are the two giant sore thumbs to me. At least I...

I added the apostrophe'd first names to the nameFixes because it looks like there's only one of each. I could move them down to the unused fnFixes if you think...

As of right now, yes. They're _exceptions_, and it seems all of the other Irish names came correctly. When new names get added to DraftExpress (and if you ever decide...

A few comments: - I actually kind of like the HoF function refactor. Conceptually, we could use this in the future to answer questions like "if this player retired right...

Oh also I think Pyramid size should dynamically scale. We don't need Top 100 in the first five seasons and Top 100 probably wouldn't be enough after five hundred seasons.

I'm saying it shouldn't cap at 100 at all. I think it should start slowly, ramp up, peak speed around 20 or 50 players, slow down til 100, then have...

> Does not scale. What happens if someone with a hyphenated last name marries someone with a hyphenated last name? That is exactly what I was alluding to with the...

Exploratory data analysis: There are 5903 _unique_ first names defined in `data/names.js`. There are 7630 total across all the countries. Of these 7630, 42 include hyphens (41 uniques), 7 include...