Ben Weiss

Results 75 comments of Ben Weiss

Thanks for bringing this up. This does not look like an issue with the sample to me. Can you verify that this occurs on the sample app in this repository?

This could be a device specific issue as we don't observe this with the benchmarking sample in general. Please file a [bug against benchmarking](https://issuetracker.google.com/issues/new?component=585351&template=1235073) and include details on the device...

Thanks for your PR. Currently there are conflicts that need to be resolved before we can move on to possibly accepting your contribution. Please resolve the conflicts.

Thanks for this PR. Once you have addressed the comments and CI passes, I'd like to see this merged into main.

Unfortunately this PR fails in CI. Please address the issues so we can continue the review before possibly accepting your contribution. ``` > Task :build-logic:convention:compileKotlin e: file:///home/runner/work/nowinandroid/nowinandroid/build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/Jacoco.kt:93:22 Unresolved reference. None...

This PR looks good to me. Please resolve the merge conflicts so we can do a final pass before merging.

This PR has a lot of conflicts. Do you want to continue and resolve these, @SimonMarquis ?

Good to hear that you're interested in picking this back up again. @JoseAlcerreca can you chime in on the likelihood of this PR being integrated into main?

Thank you for submitting this pull request. We have decided not to accept it at this time. Feel free to comment or open an issue for further discussion if necessary.

This PR has many conflicts due to the updated style. This is likely going to cause cascading issues with existing contributors that use the existing code style. Let's hold off...