nowinandroid icon indicating copy to clipboard operation
nowinandroid copied to clipboard

Fix TODO: Collect all java and kotlin source directories from the variant's source sets

Open baksha97 opened this issue 1 year ago • 1 comments

Description

Fixes lingering TODO for Jacoco source sets.

baksha97 avatar Oct 02 '24 01:10 baksha97

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 02 '24 01:10 google-cla[bot]

Unfortunately this PR fails in CI. Please address the issues so we can continue the review before possibly accepting your contribution.

> Task :build-logic:convention:compileKotlin
e: file:///home/runner/work/nowinandroid/nowinandroid/build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/Jacoco.kt:93:22 Unresolved reference. None of the following candidates is applicable because of receiver type mismatch: 
public inline fun <T, R> Array<out TypeVariable(T)>.map(transform: (TypeVariable(T)) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> BooleanArray.map(transform: (Boolean) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> ByteArray.map(transform: (Byte) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> CharArray.map(transform: (Char) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> CharSequence.map(transform: (Char) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.text
public inline fun <R> DoubleArray.map(transform: (Double) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> FloatArray.map(transform: (Float) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> IntArray.map(transform: (Int) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> LongArray.map(transform: (Long) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R, T> Result<TypeVariable(T)>.map(transform: (value: TypeVariable(T)) -> TypeVariable(R)): Result<TypeVariable(R)> defined in kotlin
public inline fun <R> ShortArray.map(transform: (Short) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> UByteArray.map(transform: (UByte) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> UIntArray.map(transform: (UInt) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> ULongArray.map(transform: (ULong) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> UShortArray.map(transform: (UShort) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <T, R> Iterable<TypeVariable(T)>.map(transform: (TypeVariable(T)) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <K, V, R> Map<out TypeVariable(K), TypeVariable(V)>.map(transform: (Map.Entry<TypeVariable(K), TypeVariable(V)>) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public fun <T, R> Sequence<TypeVariable(T)>.map(transform: (TypeVariable(T)) -> TypeVariable(R)): Sequence<TypeVariable(R)> defined in kotlin.sequences
e: file:///home/runner/work/nowinandroid/nowinandroid/build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/Jacoco.kt:93:28 Unresolved reference: it
e: file:///home/runner/work/nowinandroid/nowinandroid/build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/Jacoco.kt:93:46 Unresolved reference: it

keyboardsurfer avatar Dec 11 '24 10:12 keyboardsurfer

Unfortunately this PR fails in CI. Please address the issues so we can continue the review before possibly accepting your contribution.

> Task :build-logic:convention:compileKotlin
e: file:///home/runner/work/nowinandroid/nowinandroid/build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/Jacoco.kt:93:22 Unresolved reference. None of the following candidates is applicable because of receiver type mismatch: 
public inline fun <T, R> Array<out TypeVariable(T)>.map(transform: (TypeVariable(T)) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> BooleanArray.map(transform: (Boolean) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> ByteArray.map(transform: (Byte) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> CharArray.map(transform: (Char) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> CharSequence.map(transform: (Char) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.text
public inline fun <R> DoubleArray.map(transform: (Double) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> FloatArray.map(transform: (Float) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> IntArray.map(transform: (Int) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> LongArray.map(transform: (Long) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R, T> Result<TypeVariable(T)>.map(transform: (value: TypeVariable(T)) -> TypeVariable(R)): Result<TypeVariable(R)> defined in kotlin
public inline fun <R> ShortArray.map(transform: (Short) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> UByteArray.map(transform: (UByte) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> UIntArray.map(transform: (UInt) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> ULongArray.map(transform: (ULong) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <R> UShortArray.map(transform: (UShort) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <T, R> Iterable<TypeVariable(T)>.map(transform: (TypeVariable(T)) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public inline fun <K, V, R> Map<out TypeVariable(K), TypeVariable(V)>.map(transform: (Map.Entry<TypeVariable(K), TypeVariable(V)>) -> TypeVariable(R)): List<TypeVariable(R)> defined in kotlin.collections
public fun <T, R> Sequence<TypeVariable(T)>.map(transform: (TypeVariable(T)) -> TypeVariable(R)): Sequence<TypeVariable(R)> defined in kotlin.sequences
e: file:///home/runner/work/nowinandroid/nowinandroid/build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/Jacoco.kt:93:28 Unresolved reference: it
e: file:///home/runner/work/nowinandroid/nowinandroid/build-logic/convention/src/main/kotlin/com/google/samples/apps/nowinandroid/Jacoco.kt:93:46 Unresolved reference: it

This should be resolved now.

baksha97 avatar Dec 16 '24 20:12 baksha97