kevkevin

Concept ACK was able to run the functional test on my local and it ran fine, still want to test on regtest but still new to the project so still...

I like this idea, we should have an option to enable or disable in settings as well incase people think it feels cluttered

> Will this be merged? I think the maintainers of this repo haven't been very active but you can always make your own fork off of this and use that...

ACK amp enablement would be nice

I tested this by creating a loop similar to how @maflcko found an issue in https://github.com/bitcoin/bitcoin/pull/28831 I also noticed that in this test we only perturbed one `blk?????.dat` file which...

Concept ACK [3520d28](https://github.com/bitcoin/bitcoin/pull/29736/commits/3520d28a6e9ff704eabd8d445ad8f6fe4154e5c8) just an observation, It seems like we only use `block_hash=None` in `feature_block.py` > Something that may be worth discussing is whether we want to assert that the...

I just tried with `return block_hash == last_getheaders.locator.vHave[0]` and the tests seemed to have run fine for me. So I have no problem just checking the last `block_hash`

PR description link is routes to 404 can you update to use this https://github.com/bitcoin/bitcoin/blob/master/test/functional/wallet_multisig_descriptor_psbt.py instead?

Concept ACK [2422b90](https://github.com/bitcoin/bitcoin/pull/29156/commits/2422b90978f4ea13ee49954598dc8aef841e36df) I've done a little code review and so far it is looking good, I think it would be cool if instead of always using the pubkeys in...

ACK [7f0be89](https://github.com/bitcoin/bitcoin/pull/29156/commits/7f0be8969e721de69fc352f76db5787836803b76)