Kevin Oliver

@anukul given how long its been, I think it's safe for you to take a crack at it.

@xieliang our team lacks a windows environment so it'll be hard for us to reproduce, let alone fix.

Can you use `Struct.withoutPassthroughFields(original)` to create a copy of the struct without the pass throughs? For example: https://github.com/twitter/scrooge/blob/develop/scrooge-generator-tests/src/test/resources/gold_file_output_scala/com/twitter/scrooge/test/gold/thriftscala/Request.scala#L116

Perhaps we could add it as a method on each generated struct so that its generic? I'm open to ideas there. As for the motivations — Its very powerful to...

it'd be good if we matched apache thrift's behavior. i suspect if we didn't give users an escape valve it'd wreck havoc on them. perhaps via a "comment" to allow...

@QuantumBear yeah that looks like a bug. and worse, it looks like we have nothing in the way of tests (or even compilation!) for the demos. it probably wouldn't be...

@mosesn My guess is that there are places where we miss injecting them. @jamesbroadhead It'd be great if you could enumerate those places where it would help.

Moses, I think its only Doc-comment style (/*\* */) that is converted. But it looks like we don't do this for the generated Java code. Note that GoldService.java https://github.com/twitter/scrooge/blob/develop/scrooge-generator-tests/src/test/resources/gold_file_output_java/com/twitter/scrooge/test/gold/thriftjava/GoldService.java does...

Ah, yep another instance of this. Just like #757 . I think same sort of solution noted there could work here as well.

@adriancole What approach are other systems taking here? Its not obvious to me what the tradeoffs are between those two choices.