Kevin Kucharczyk

Results 15 comments of Kevin Kucharczyk

@knownasilya I used `v5.0.0-beta.2`

@knownasilya I've already included a zipped reproduction app in my first comment, at the very end is a link: ![Model fragments broken against Ember Data 3 28 · Issue #406...

@knownasilya that fix is not quite enough, unfortunately. If you have a fragment array, that'll fail too under 3.28 (it requires a similar fix in the fragment array serializer). Either...

This is tricky. As @michalsnik suggests, it is not quite straightforward. This rule would have to rely on the `order-in-*` rules being valid, but I don't think rules should depend...

Yeah, adding it as an option should work. I would be fine with it, I think it would be a great "nice-to-have" linter, thought I would keep the option off...

So @michalsnik and I had a chat about this rule and we came up with an alternative approach, which we believe is a nice compromise. First of all, this would...

@rwwagner90 you just made me realise that there would still be another problem if we introduce this as a separate rule: what if a developer defines a custom `order` section...

@rwwagner90 alphabetical order as well? We'll gladly accept a PR, if you're willing to implement those rules ;)

@rwwagner90 I agree, options do seem to be the best approach here, since the newline rule is so closely tied to the validity of the sectioning.

I found that there was a similar suggestion made to the Airbnb eslint base and it was not merged, with this as the reasoning: https://github.com/airbnb/javascript/pull/667#issuecomment-169913792 So similarly, I don't think...