Kevin Kreiser

this is getting very close! there are still some formatting things and i didnt review that the responses for http were exactly to spec but we can get those last...

no worries ill probably get to this tonight if i have time. sorry for it takign so long but also thank you for taking the time!

after finishing the feedback from above i think the only thing left for us to do is get unit test coverage for all of the changes. let me know when...

@ldsmoreira i will finish the review tonight. hopefully just a few suggestions to the cors handling and then we are done. i think we can forget about the configuration stuff...

going to work on some unit tests for the new functionality so we can get this merged

if you are looking for examples, i think you could make a unit test for each scenario of the cors preflight shortcutting logic. each test case should look similar to...

yep happy to help @ldsmoreira regarding question number 1 above, yep exactly, we start an http server at the beginning of the test just for this purpose of testing regarding...

https://github.com/kevinkreiser/prime_server/blob/eaa396342417323d1a80fc649ddc66cc5a221dbc/test/http.cpp#L300-L309 that is where the server is started, you can see at the bottom the tests are broken into two groups, ones that dont rely on an actual running server...

i think its happening because in this type of testing we dont actually connect a client that the server can send the shortcircuit reply to. maybe the right thing for...

yep i think for me the only thing we need to worry about at this point is that the behavior is as it was before so that people who are...