Kevin Kreiser

for directions type, the old way was a single boolean that turned narrative on or off, which is still in deprecated support: https://github.com/valhalla/valhalla/blob/90ae30e00936c4857a6595a103acc522b1b3380f/src/worker.cc#L680-L690 this happened in #1602

good catch! im not sure how its getting stuck in a loop (that is the likely culprit for not returning) but one thing i see that we havent hooked up...

https://github.com/valhalla/valhalla/blob/master/valhalla/thor/dijkstras.h#L165

@chrstnbwnkl and i can review this on wednesday. to me it looks like this is pretty much done other than the warning and letting the request through. one more thing...

@chrstnbwnkl > My PR also included the ferry search filter, lets still get that one in though!

yes to both questions. max_road_class handles highway/motorway and yes we can add the other 2 filters

> How far is this PR from being merged? this pr is the top priority one for review and merging in my opinion as its the most active. id like...

@chrstnbwnkl want to debug some of these test cases tomorrow so we can come back with answers here and suggests on how to move forward?

did we need to enable or change some tests now that the bug with loki search is taken care of?

in this case its a warning being turned into an error which im just about extremely sick of dealing with. you can avoid it on your platform by turning off...